Board Thread:The Last Sovereign Discussion/@comment-45281093-20200323035243/@comment-45318410-20200327231318

Ah well I did not state myself clear enough. The comparison was between my own port attempt and your attempt where I used native MV assets for the vanilla ones as per my own preference, and that would mean some extra work other than simply overwriting the files. In your port you simply converted VA assets so there's no such problem. I just wanted to demonstrate the difference between native MV assets and converted VA assets as I strongly prefer the former.

For the script calls though, quest journal is not only the one that requires a conversion - for example there are a lot of messaging related content like ats_all etc., they can be mass replaced easily with ats_all(:message_win_height, 412) --> MessageRows 17 and the alike but nevertheless they need to be documented for others to see what you have been doing (in my case for example I used 16 rows instead of 17, without documentation there may be some consistency issues).

There are also more complicated cases, like showing two messages simultaneously - the original msg script call needs to either go through a shim (I did that, but it involves injecting code into vanilla methods using alias) or replaced with added plugin command after the next message box command like what you did. I would need to write a program to help me with that process if I do not want to manually add everything since I can't think of a way to achieve that with simple text replace function. Even if it is to be done manually a guide of what to do would be greatly appreciated.

In conclusion, others would not be of much help in maintaning the repo if they have to dig into the code and see what you did with those non-'convert-and-play' bits by themselves, and that is the documentation I am talking about.

Anyway thanks a lot for your port, it finally gave me the motivation of replaying again from the beginning with optimisation in mind and that's what I am doing right now :P